Skip to content

srt::FixedArray: define an iterator, changed exception throwing. #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2022
Merged

srt::FixedArray: define an iterator, changed exception throwing. #2298

merged 2 commits into from
Apr 20, 2022

Conversation

maxsharabayko
Copy link
Collaborator

  • Defined an iterator for the srt::FixedArray. Also fixes potentially throwing an exception from the CRcvBufferNew destructor because the operator[] was used.
  • Removed the member variable holding the error string. Instead form the string dynamically.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Apr 14, 2022
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Apr 14, 2022
@maxsharabayko maxsharabayko force-pushed the hotfix/fixed-arrat-iterator branch from 65d9725 to 7d9dec7 Compare April 14, 2022 14:36
@maxsharabayko maxsharabayko mentioned this pull request Apr 14, 2022
Merged
@jlsantiago0
Copy link
Contributor

Builds fine on GCC-4.4 and later.

@maxsharabayko maxsharabayko merged commit c0da44e into Haivision:master Apr 20, 2022
@maxsharabayko maxsharabayko deleted the hotfix/fixed-arrat-iterator branch April 20, 2022 08:31
@tt2468 tt2468 mentioned this pull request Aug 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@maxsharabayko @jlsantiago0