feat: Enhance Training Mode Selector and Vital Point Training Panel #172

pethers · 2025-07-24T14:42:11Z

Updated TrainingModeSelector to include descriptions, colors, and icons for each mode.
Improved layout and styling of buttons in TrainingModeSelector for better UX.
Added a description panel below the mode buttons in TrainingModeSelector.
Refactored VitalPointTrainingPanel to enhance UI with improved styling and layout.
Introduced new selection background and severity indicators in VitalPointTrainingPanel.
Updated input handling system to support player movement and combat controls with enhanced performance.
Added support for stance changes and combat actions in the input system.

- Updated TrainingModeSelector to include descriptions, colors, and icons for each mode. - Improved layout and styling of buttons in TrainingModeSelector for better UX. - Added a description panel below the mode buttons in TrainingModeSelector. - Refactored VitalPointTrainingPanel to enhance UI with improved styling and layout. - Introduced new selection background and severity indicators in VitalPointTrainingPanel. - Updated input handling system to support player movement and combat controls with enhanced performance. - Added support for stance changes and combat actions in the input system.

…formance and movement controls

… and improved UI transparency

…en and TrainingScreen

…e unnecessary comments

… combat dynamics

Copilot

Pull Request Overview

This pull request enhances the Training Mode by adding comprehensive improvements to the user interface and input handling system. The changes focus on providing better visual feedback, clearer mode differentiation, and enhanced interactivity for vital point training.

Enhanced Training Mode Selector with detailed descriptions, icons, and color-coded modes
Improved Vital Point Training Panel with better styling, pulse animations, and enhanced vital point information display
Refactored input system to support both player movement and combat controls with improved performance and responsiveness

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/utils/inputSystem.ts	Complete rewrite of input system with enhanced player movement, combat input handling, and performance optimizations
src/components/training/components/VitalPointTrainingPanel.tsx	Enhanced UI with improved styling, pulse animations, severity indicators, and better Korean typography
src/components/training/components/TrainingModeSelector.tsx	Added mode descriptions, icons, colors, and improved button layout with enhanced visual feedback
src/components/training/components/TrainingDummy.tsx	Simplified and optimized dummy implementation using Korean vital points data
src/components/training/components/TrainingControlsPanel.tsx	Enhanced panel with status indicators, improved button design, and better Korean text integration
src/components/training/TrainingScreen.tsx	Major refactor with improved layout, enhanced player movement integration, and better mobile support
src/components/combat/CombatScreen.tsx	Updated to use new input system with improved AI behavior and arena bounds
.vscode/settings.json	Performance optimizations for TypeScript development
.devcontainer/init-xvfb.sh	Commented out Xvfb initialization for development environment optimization

Comments suppressed due to low confidence (2)

src/components/training/TrainingScreen.tsx:117

The arenaBounds dependency in the movement configuration may cause unnecessary re-initialization of the movement system when bounds change. Consider memoizing or stabilizing this reference.

          "geon",

Copilot · 2025-07-24T16:21:12Z

src/utils/inputSystem.ts

+      if (!enabled) return;
+
+      const key = event.key.toLowerCase();
+      pressedKeys.current.add(key);


Consider using a Set-based approach with proper cleanup to avoid memory leaks. The current implementation may accumulate keys if cleanup fails.

Copilot · 2025-07-24T16:21:12Z

src/utils/inputSystem.ts

+    window.removeEventListener("keydown", this.handleKeyDown.bind(this));
+    window.removeEventListener("keyup", this.handleKeyUp.bind(this));


This event listener removal will not work correctly because bind(this) creates a new function reference each time. Store the bound function reference during setup to properly remove the listener.

Suggested change

window.removeEventListener("keydown", this.handleKeyDown.bind(this));

window.removeEventListener("keyup", this.handleKeyUp.bind(this));

window.removeEventListener("keydown", this.boundHandleKeyDown);

window.removeEventListener("keyup", this.boundHandleKeyUp);

Copilot · 2025-07-24T16:21:13Z

src/components/training/components/VitalPointTrainingPanel.tsx

+          g.fill();
+
+          // Animated border with proper pulse calculation
+          const pulse = 1 + Math.sin(Date.now() * 0.005) * 0.3;


Using Date.now() in a draw function that's called frequently can cause performance issues. Consider using a timestamp passed from an animation frame or a more efficient timing mechanism.

Suggested change

const pulse = 1 + Math.sin(Date.now() * 0.005) * 0.3;

const pulse = 1 + Math.sin(timestamp * 0.005) * 0.3;

Copilot · 2025-07-24T16:21:13Z

src/components/training/components/TrainingControlsPanel.tsx

+
+            // Pulsing effect when training
+            if (isTraining) {
+              const pulse = 1 + Math.sin(Date.now() * 0.005) * 0.3;


Similar to the vital point panel, using Date.now() in draw functions can impact performance. Consider using a shared animation timer or RAF-based timing.

Copilot · 2025-07-24T16:21:13Z

src/components/training/components/TrainingDummy.tsx

+    // Training glow effect
+    if (isTraining) {
+      g.stroke({ width: 1, color: KOREAN_COLORS.ACCENT_GOLD, alpha: 0.3 });
+      g.circle(0, 0, 70 + Math.sin(Date.now() * 0.003) * 5);


Another instance of Date.now() in a draw function. This pattern appears multiple times and should be addressed consistently across all components.

Copilot · 2025-07-24T16:21:14Z

src/utils/inputSystem.ts

+      const key = event.key.toLowerCase();
+      pressedKeys.current.add(key);
+
+      // ✅ FIXED: Add all movement keys including WASD and arrows


Development/debugging comments like '✅ FIXED:' should be removed from production code.

Suggested change

// ✅ FIXED: Add all movement keys including WASD and arrows

Copilot · 2025-07-24T16:21:14Z

src/utils/inputSystem.ts

+      const key = event.key.toLowerCase();
+      pressedKeys.current.delete(key);
+
+      // ✅ FIXED: Handle key release for all movement keys


Another development comment that should be removed from production code.

Suggested change

// ✅ FIXED: Handle key release for all movement keys

Copilot · 2025-07-24T16:21:14Z

src/utils/inputSystem.ts

+    [enabled]
+  );
+
+  // ✅ FIXED: Proper movement calculation with correct bounds


Development comment should be removed from production code.

Suggested change

// ✅ FIXED: Proper movement calculation with correct bounds

sonarqubecloud · 2025-07-24T16:29:23Z

Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

pethers requested a review from Copilot July 24, 2025 14:42

github-actions bot added ui User interface improvements needs-tests Needs test coverage labels Jul 24, 2025

This comment was marked as outdated.

Sign in to view

pethers added 2 commits July 24, 2025 16:43

Merge branch 'main' into trains2

3daad59

feat: Enhance TypeScript settings and input handling for improved per…

4f57d6d

…formance and movement controls

github-actions bot added infrastructure CI/CD and build infrastructure config Configuration changes labels Jul 24, 2025

pethers added 2 commits July 24, 2025 16:07

feat: Enhance TrainingScreen with feedback handling, ESC key support,…

36d7930

… and improved UI transparency

refactor: Comment out Xvfb startup and readiness checks for clarity

8658990

github-actions bot added the devcontainer Development container updates label Jul 24, 2025

pethers requested a review from Copilot July 24, 2025 16:11

This comment was marked as outdated.

Sign in to view

pethers added 3 commits July 24, 2025 16:17

refactor: Remove commented-out code and improve clarity in CombatScre…

4f60409

…en and TrainingScreen

refactor: Clean up movement state and player movement function, remov…

6ff352c

…e unnecessary comments

refactor: Update AI action cooldown and aggression level for improved…

9c7e958

… combat dynamics

pethers requested a review from Copilot July 24, 2025 16:19

Merge branch 'main' into trains2

99b5955

Copilot AI reviewed Jul 24, 2025

View reviewed changes

Update init-xvfb.sh

036ab6d

pethers merged commit a3a9d18 into main Jul 24, 2025
12 of 13 checks passed

pethers deleted the trains2 branch July 24, 2025 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Enhance Training Mode Selector and Vital Point Training Panel #172

feat: Enhance Training Mode Selector and Vital Point Training Panel #172

Uh oh!

pethers commented Jul 24, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 24, 2025

Uh oh!

Copilot AI Jul 24, 2025

Uh oh!

Copilot AI Jul 24, 2025

Uh oh!

Copilot AI Jul 24, 2025

Uh oh!

Copilot AI Jul 24, 2025

Uh oh!

Copilot AI Jul 24, 2025

Uh oh!

Copilot AI Jul 24, 2025

Uh oh!

Copilot AI Jul 24, 2025

Uh oh!

sonarqubecloud bot commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

		window.removeEventListener("keydown", this.handleKeyDown.bind(this));
		window.removeEventListener("keyup", this.handleKeyUp.bind(this));

	const pulse = 1 + Math.sin(Date.now() * 0.005) * 0.3;
	const pulse = 1 + Math.sin(timestamp * 0.005) * 0.3;

	// ✅ FIXED: Add all movement keys including WASD and arrows

feat: Enhance Training Mode Selector and Vital Point Training Panel #172

feat: Enhance Training Mode Selector and Vital Point Training Panel #172

Uh oh!

Conversation

pethers commented Jul 24, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jul 24, 2025

Quality Gate failed

Uh oh!

Uh oh!

Uh oh!