ci: Read env variable from os environment, not from nox #1869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
approved these changes
Feb 17, 2025
stubbiali
pushed a commit
to stubbiali/gt4py
that referenced
this pull request
Aug 19, 2025
Contains two types of changes: - Cleanup of `DOCKER_BUILD_ARGS`: this variable is passed to the docker build, but not used, which occasionally triggers an unnecessary rebuild. - As consequence of `DOCKER_BUILD_ARGS` cleanup the base image has been rebuilt. In the new image we pull a new nox version, which removes the os environment variables from the nox session environment (refer to nox PR wntrblm/nox#874). Therefore, such variables need to be read from the os environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains two types of changes:
DOCKER_BUILD_ARGS: this variable is passed to the docker build, but not used, which occasionally triggers an unnecessary rebuild.DOCKER_BUILD_ARGScleanup the base image has been rebuilt. In the new image we pull a new nox version, which removes the os environment variables from the nox session environment (refer to nox PR fix: outer_env issues fixed wntrblm/nox#874). Therefore, such variables need to be read from the os environment.