Skip to content

nits: incorrect condition stmt for options.Excludes #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

nits: incorrect condition stmt for options.Excludes #1929

merged 1 commit into from
Mar 26, 2025

Conversation

Shion1305
Copy link
Contributor

@Shion1305 Shion1305 commented Sep 28, 2024 •
edited
Loading

In cmd/import.go, there is an implementation that checks whether Excludes options is specified.
The default value for options.Excludes is []string{} as you can see here:

terraformer/cmd/import.go

Lines 395 to 410 in a5b4b69

func baseProviderFlags(flag *pflag.FlagSet, options *ImportOptions, sampleRes, sampleFilters string) {
flag.BoolVarP(&options.Connect, "connect", "c", true, "")
flag.BoolVarP(&options.Compact, "compact", "C", false, "")
flag.StringSliceVarP(&options.Resources, "resources", "r", []string{}, sampleRes)
flag.StringSliceVarP(&options.Excludes, "excludes", "x", []string{}, sampleRes)
flag.StringVarP(&options.PathPattern, "path-pattern", "p", DefaultPathPattern, "{output}/{provider}/")
flag.StringVarP(&options.PathOutput, "path-output", "o", DefaultPathOutput, "")
flag.StringVarP(&options.State, "state", "s", DefaultState, "local or bucket")
flag.StringVarP(&options.Bucket, "bucket", "b", "", "gs://terraform-state")
flag.StringSliceVarP(&options.Filter, "filter", "f", []string{}, sampleFilters)
flag.BoolVarP(&options.Verbose, "verbose", "v", false, "")
flag.BoolVarP(&options.NoSort, "no-sort", "S", false, "set to disable sorting of HCL")
flag.StringVarP(&options.Output, "output", "O", "hcl", "output format hcl or json")
flag.IntVarP(&options.RetryCount, "retry-number", "n", 5, "number of retries to perform when refresh fails")
flag.IntVarP(&options.RetrySleepMs, "retry-sleep-ms", "m", 300, "time in ms to sleep between retries")
}

However, the condition statement for checking options.Excludes is if options.Excludes != nil.

terraformer/cmd/import.go

Line 127 in a5b4b69

if options.Excludes != nil {

As default value for options.Excludes is []string{}, this always results true.

This should be fixed as len(options.Excludes) > 0
This does not cause panic when option.Excludes is false as you can see here

You can see similar implementation here:

terraformer/cmd/provider_cmd_aws.go

Line 53 in ceb25e2

if len(options.Resources) > 0 { // don't import anything and potentially override global resources

@github-actions github-actions bot added the Stale label Nov 29, 2024
@sergeylanzman sergeylanzman reopened this Mar 26, 2025
@sergeylanzman sergeylanzman enabled auto-merge (squash) March 26, 2025 21:29
@sergeylanzman sergeylanzman merged commit 930ce5b into GoogleCloudPlatform:master Mar 26, 2025
2 of 4 checks passed
@yashuatla yashuatla mentioned this pull request Jun 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeylanzman sergeylanzman sergeylanzman approved these changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shion1305 @sergeylanzman