Skip to content

doc: how-to guide on using legacy code #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2021
Merged

doc: how-to guide on using legacy code #334

merged 3 commits into from
Oct 18, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 18, 2021

Fixes #312

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021 •
edited
Loading

Codecov Report

Merging #334 (d2f8791) into main (d5cfcaf) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   88.79%   88.82%   +0.03%     
==========================================
  Files          91       93       +2     
  Lines        2605     2614       +9     
==========================================
+ Hits         2313     2322       +9     
  Misses        292      292
Impacted Files Coverage Δ
...les/howto_use_legacy_code/howto_use_legacy_code.cc 100.00% <100.00%> (ø)
examples/howto_use_legacy_code/legacy/legacy.cc 100.00% <100.00%> (ø)
examples/http_examples_test.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cfcaf...d2f8791. Read the comment docs.

@coryan coryan marked this pull request as ready for review October 18, 2021 16:31
@coryan coryan requested a review from a team as a code owner October 18, 2021 16:31
@coryan coryan enabled auto-merge (squash) October 18, 2021 16:31
@coryan coryan merged commit 4c02a74 into GoogleCloudPlatform:main Oct 18, 2021
@coryan coryan deleted the doc-howto-use-legacy-code branch October 18, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an example using Make or some other non-CMake build for legacy code
2 participants
@coryan @devbww