Skip to content

feat: support mapping of legacy GCF events #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Aug 13, 2021
Merged

feat: support mapping of legacy GCF events #313

merged 22 commits into from
Aug 13, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Aug 13, 2021 •
edited
Loading

With this change the framework can receive GCF events and deliver them as Cloud Events.

Part of the work for #306

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021 •
edited
Loading

Codecov Report

Merging #313 (84940ae) into main (0784827) will increase coverage by 0.81%.
The diff coverage is 97.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   55.50%   56.32%   +0.81%     
==========================================
  Files         562      564       +2     
  Lines       15205    15437     +232     
==========================================
+ Hits         8440     8695     +255     
+ Misses       6765     6742      -23
Impacted Files Coverage Δ
google/cloud/functions/cloud_event.cc 100.00% <ø> (ø)
...cloud/functions/internal/parse_cloud_event_http.cc 97.50% <94.11%> (-2.50%) ⬇️
...unctions/internal/parse_cloud_event_legacy_test.cc 97.61% <97.61%> (ø)
...oud/functions/internal/parse_cloud_event_legacy.cc 97.72% <97.72%> (ø)
.../boost/intrusive/detail/bstree_algorithms_base.hpp 90.32% <0.00%> (-3.23%) ⬇️
...installed/x64-linux/include/gtest/gtest-printers.h 0.00% <0.00%> (ø)
...x/include/nlohmann/detail/input/input_adapters.hpp 100.00% <0.00%> (ø)
.../x64-linux/include/nlohmann/detail/input/lexer.hpp 26.28% <0.00%> (+0.16%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0784827...84940ae. Read the comment docs.

@coryan coryan marked this pull request as ready for review August 13, 2021 14:34
@coryan coryan requested a review from a team as a code owner August 13, 2021 14:34
@coryan coryan enabled auto-merge (squash) August 13, 2021 14:44
devjgm
devjgm approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple small questions.

@coryan coryan disabled auto-merge August 13, 2021 15:13
@coryan coryan enabled auto-merge (squash) August 13, 2021 15:32
@coryan coryan disabled auto-merge August 13, 2021 16:32
@coryan coryan merged commit 20ee5cf into GoogleCloudPlatform:main Aug 13, 2021
@coryan coryan deleted the feat-support-more-cloud-event-mappings branch August 13, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@devjgm devjgm devjgm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryan @devjgm