Skip to content

feat: improve error message for CloudEvent #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

feat: improve error message for CloudEvent #310

merged 1 commit into from
Aug 12, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Aug 12, 2021

When parsing CloudEvents in JSON format the error message was a bit
obscure, it indicated that a field was missing, but not which one. This
is more readable in the common case.

@coryan
feat: improve error message for CloudEvent
b146449 
When parsing CloudEvents in JSON format the error message was a bit
obscure, it indicated that a field was missing, but not which one. This
is more readable in the common case.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@coryan coryan marked this pull request as ready for review August 12, 2021 15:49
@coryan coryan requested a review from a team as a code owner August 12, 2021 15:49
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #310 (b146449) into main (bf2ba9a) will decrease coverage by 33.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #310       +/-   ##
===========================================
- Coverage   88.79%   55.47%   -33.32%     
===========================================
  Files          88      562      +474     
  Lines        2303    15105    +12802     
===========================================
+ Hits         2045     8380     +6335     
- Misses        258     6725     +6467
Impacted Files Coverage Δ
...cloud/functions/internal/parse_cloud_event_json.cc 100.00% <100.00%> (ø)
...ux/include/boost/asio/impl/multiple_exceptions.ipp 0.00% <0.00%> (ø)
...ude/boost/archive/iterators/dataflow_exception.hpp 0.00% <0.00%> (ø)
.../include/boost/algorithm/string/classification.hpp 0.00% <0.00%> (ø)
...nclude/google/cloud/spanner/internal/tuple_utils.h 0.00% <0.00%> (ø)
...nux/include/boost/algorithm/string/detail/util.hpp 0.00% <0.00%> (ø)
...64-linux/include/boost/beast/core/detail/tuple.hpp 100.00% <0.00%> (ø)
...ux/include/google/cloud/storage/download_options.h 0.00% <0.00%> (ø)
...x/include/boost/program_options/value_semantic.hpp 77.77% <0.00%> (ø)
...e/boost/intrusive/detail/default_header_holder.hpp 100.00% <0.00%> (ø)
... and 465 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf2ba9a...b146449. Read the comment docs.

@coryan coryan merged commit e283cf9 into GoogleCloudPlatform:main Aug 12, 2021
@coryan coryan deleted the feat-improve-cloud-event-json-parsing-error-message branch August 12, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@devjgm devjgm devjgm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryan @devjgm