Skip to content

feat: more efficient access to HttpRequest data #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2021
Merged

feat: more efficient access to HttpRequest data #300

merged 2 commits into from
Feb 28, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 28, 2021

Some applications may want to move the contents of a HttpRequest.

@coryan
feat: more efficient access to HttpRequest data
a43b939 
Some applications may want to move the contents of a HttpRequest.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2021
@codecov
Copy link

codecov bot commented Feb 28, 2021 •
edited
Loading

Codecov Report

Merging #300 (e418342) into main (52ac0f8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   88.78%   88.79%           
=======================================
  Files          88       88           
  Lines        2301     2303    +2     
=======================================
+ Hits         2043     2045    +2     
  Misses        258      258
Impacted Files Coverage Δ
examples/site/http_form_data/http_form_data.cc 100.00% <100.00%> (ø)
google/cloud/functions/http_request.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ac0f8...e418342. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 28, 2021 16:55
@coryan coryan requested a review from a team as a code owner February 28, 2021 16:55
@coryan coryan merged commit 179a2f9 into GoogleCloudPlatform:main Feb 28, 2021
@coryan coryan deleted the feat-add-refref-accessor-to-http-request-data branch February 28, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@devjgm devjgm devjgm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryan @devjgm