Skip to content

feat: make HttpResponse fluent #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2021
Merged

feat: make HttpResponse fluent #293

merged 4 commits into from
Feb 21, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 21, 2021 •
edited
Loading

In many cases we want to set one or two attributes of a response and
then return it, as in:

return HttpResponse{}.set_result(HttpResponse::kNotFound);

This makes it easy to do so, and changes the examples to take advantage
of this feature.

@coryan
feat: make HttpResponse fluent
d8f2d45 
In many cases we want to set one or two attributes of a response and
then return it, as it:

```cc
return HttpResponse{}.set_result(HttpResponse::kNotFound);
```

This makes it easy to do so, and changes the examples to take advantage
of this feature.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2021
@codecov
Copy link

codecov bot commented Feb 21, 2021 •
edited
Loading

Codecov Report

Merging #293 (a4f0c39) into main (274ce48) will increase coverage by 0.00%.
The diff coverage is 93.57%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   88.55%   88.56%           
=======================================
  Files          87       87           
  Lines        2255     2230   -25     
=======================================
- Hits         1997     1975   -22     
+ Misses        258      255    -3
Impacted Files Coverage Δ
...tutorial_cloud_bigtable/tutorial_cloud_bigtable.cc 0.00% <0.00%> (ø)
...e/tutorial_cloud_spanner/tutorial_cloud_spanner.cc 0.00% <0.00%> (ø)
examples/hello_gcs/hello_gcs.cc 43.75% <25.00%> (-3.62%) ⬇️
...mples/hello_from_namespace/hello_from_namespace.cc 100.00% <100.00%> (ø)
...om_nested_namespace/hello_from_nested_namespace.cc 100.00% <100.00%> (ø)
...s/hello_multiple_sources/hello_multiple_sources.cc 100.00% <100.00%> (ø)
...s/hello_with_third_party/hello_with_third_party.cc 100.00% <100.00%> (ø)
examples/hello_world/hello_world.cc 100.00% <100.00%> (ø)
...concepts_after_response/concepts_after_response.cc 100.00% <100.00%> (ø)
...e/concepts_after_timeout/concepts_after_timeout.cc 100.00% <100.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 274ce48...015f045. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 21, 2021 04:12
@coryan coryan requested a review from a team as a code owner February 21, 2021 04:12
devbww
devbww approved these changes Feb 21, 2021
View reviewed changes
@coryan coryan merged commit 8022146 into GoogleCloudPlatform:main Feb 21, 2021
@coryan coryan deleted the feat-make-http-response-fluent branch February 21, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryan @devbww