Skip to content

fix: build problems with MSVC #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2021
Merged

fix: build problems with MSVC #288

merged 2 commits into from
Feb 20, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 19, 2021

Caught these problems when trying to send a PR for vcpkg. I really need a CI build for MSVC.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021 •
edited
Loading

Codecov Report

Merging #288 (27eb230) into main (997b994) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files          87       87           
  Lines        2254     2255    +1     
=======================================
+ Hits         1996     1997    +1     
  Misses        258      258
Impacted Files Coverage Δ
google/cloud/functions/internal/base64_decode.cc 100.00% <ø> (ø)
examples/site_test.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997b994...b3e5103. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 19, 2021 23:28
@coryan coryan requested a review from a team as a code owner February 19, 2021 23:28
@coryan coryan merged commit 955a412 into GoogleCloudPlatform:main Feb 20, 2021
@coryan coryan deleted the fix-build-failures-with-msvc branch February 20, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryan @devbww