feat: convert storage Pub/Sub events #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 89.49% 90.19% +0.69%
==========================================
Files 80 82 +2
Lines 1942 2080 +138
==========================================
+ Hits 1738 1876 +138
Misses 204 204
Continue to review full report at Codecov.
|
At the moment there is no way to deliver storage notifications in CloudEvent format for a function deployed in Cloud Run. This change adds a shim to parse Pub/Sub messages created by storage notifications as if they were storage events.
devbww
approved these changes
Feb 19, 2021
google/cloud/functions/internal/parse_cloud_event_storage_test.cc
Outdated
Show resolved
Hide resolved
google/cloud/functions/internal/parse_cloud_event_storage_test.cc
Outdated
Show resolved
Hide resolved
google/cloud/functions/internal/parse_cloud_event_storage_test.cc
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment there is no way to deliver storage notifications in
CloudEvent format for a function deployed in Cloud Run. This change adds
a shim to parse Pub/Sub messages created by storage notifications as if
they were storage events.
Part of the work for #100