Skip to content

feat: how-to guide using Cloud Build for builder #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2021
Merged

feat: how-to guide using Cloud Build for builder #267

merged 2 commits into from
Feb 17, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 17, 2021

Fixes #235

@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #267 (c52bda2) into main (d3a4082) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   89.41%   89.46%   +0.04%     
==========================================
  Files          78       78              
  Lines        1947     1946       -1     
==========================================
  Hits         1741     1741              
+ Misses        206      205       -1
Impacted Files Coverage Δ
...le/cloud/functions/internal/framework_impl_test.cc 97.59% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a4082...df242af. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 17, 2021 20:37
@coryan coryan requested a review from a team as a code owner February 17, 2021 20:37
@coryan
Copy link
Contributor Author

coryan commented Feb 17, 2021

/cc: @grant this shows people how to offload the builder creation to Cloud Build.

grant
grant approved these changes Feb 17, 2021
View reviewed changes
devbww
devbww reviewed Feb 17, 2021
View reviewed changes
@coryan
Copy link
Contributor Author

coryan commented Feb 17, 2021

PTAL

@coryan coryan merged commit 6f7553c into GoogleCloudPlatform:main Feb 17, 2021
@coryan coryan deleted the feat-offload-pack-creation-to-cloud-build branch February 17, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@grant grant grant approved these changes

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Cloud Build script to setup the buildpacks builder
3 participants
@coryan @grant @devbww