Skip to content

feat: implement http_system_test example #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

feat: implement http_system_test example #193

merged 1 commit into from
Jan 21, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 21, 2021

Fixes #81

@snippet-bot
Copy link

snippet-bot bot commented Jan 21, 2021

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #193 (9b04f7a) into main (4a1502c) will decrease coverage by 0.11%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   97.42%   97.31%   -0.12%     
==========================================
  Files          65       65              
  Lines        1556     1563       +7     
==========================================
+ Hits         1516     1521       +5     
- Misses         40       42       +2
Impacted Files Coverage Δ
...xamples/site/testing_http/http_integration_test.cc 85.24% <81.81%> (-1.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a1502c...9b04f7a. Read the comment docs.

@coryan coryan marked this pull request as ready for review January 21, 2021 13:59
@coryan coryan requested a review from a team as a code owner January 21, 2021 13:59
@coryan coryan merged commit 6f19afc into GoogleCloudPlatform:main Jan 21, 2021
@coryan coryan deleted the feat-implement-http_system_test-example branch January 21, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@devjgm devjgm devjgm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement example: functions_http_system_test
2 participants
@coryan @devjgm