Skip to content

Conversation

braydonk
Copy link

@braydonk braydonk commented Mar 11, 2023

The previous commit to add support for openssl1.1.1t (#402) missed the step of adding the checksum to the config. This PR adds the checksum for the openssl1.1.1t tar file.

The sha256 was acquired by the following steps:

curl -LO https://www.openssl.org/source/openssl-1.1.1t.tar.gz
sha256sum openssl-1.1.1t.tar.gz

The previous commit to add support for openssl1.1.1t missed the step of
adding the checksum to the config. This PR adds the checksum for the
openssl1.1.1t tar file.

The sha256 was acquired by the following steps:

```bash
curl -LO https://www.openssl.org/source/openssl-1.1.1t.tar.gz
sha256sum openssl-1.1.1t.tar.gz
```
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sha256 was acquired by the following steps:

curl -LO https://www.openssl.org/source/openssl-1.1.1t.tar.gz
sha256sum openssl-1.1.1t.tar.gz

Also here: https://github.com/chef/omnibus-software/blob/main/config/software/openssl.rb#L55 😁

Comment on lines 52 to 54
version("1.1.1q") { source sha256: "d7939ce614029cdff0b6c20f0e2e5703158a489a72b2507b8bd51bf8c8fd10ca" }
version("1.1.1l") { source sha256: "0b7a3e5e59c34827fe0c3a74b7ec8baef302b98fa80088d7f9153aa16fa76bd1" }
version("1.1.1t") { source sha256: "8dee9b24bdb1dcbf0c3d1e9b02fb8f6bf22165e807f45adeb7c9677536859d3b" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version("1.1.1q") { source sha256: "d7939ce614029cdff0b6c20f0e2e5703158a489a72b2507b8bd51bf8c8fd10ca" }
version("1.1.1l") { source sha256: "0b7a3e5e59c34827fe0c3a74b7ec8baef302b98fa80088d7f9153aa16fa76bd1" }
version("1.1.1t") { source sha256: "8dee9b24bdb1dcbf0c3d1e9b02fb8f6bf22165e807f45adeb7c9677536859d3b" }
version("1.1.1t") { source sha256: "8dee9b24bdb1dcbf0c3d1e9b02fb8f6bf22165e807f45adeb7c9677536859d3b" }
version("1.1.1q") { source sha256: "d7939ce614029cdff0b6c20f0e2e5703158a489a72b2507b8bd51bf8c8fd10ca" }
version("1.1.1l") { source sha256: "0b7a3e5e59c34827fe0c3a74b7ec8baef302b98fa80088d7f9153aa16fa76bd1" }

Let's keep them sorted (reverse chronological).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alphabet sure is tricky sometimes

@braydonk
Copy link
Author

The sha256 was acquired by the following steps:

curl -LO https://www.openssl.org/source/openssl-1.1.1t.tar.gz
sha256sum openssl-1.1.1t.tar.gz

Also here: https://github.com/chef/omnibus-software/blob/main/config/software/openssl.rb#L55 grin

Oof, didn't notice that. Oh well, didn't take too long 😅

Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@braydonk braydonk merged commit eb0ad49 into GoogleCloudPlatform:master Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants