Add templated determinant function and LU decomposition inverse to kMatrixUtils #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
approved these changes
Mar 16, 2022
|
Is this okay to go in? |
|
No, but I do think we should replace the matrix inversion in the k-matrix with LU decomposition before the hackathon. I can get this ready to go tomorrow. |
…oFit/GooFit into tboettch_template_determinant
|
This should be ready to go once all tests pass. I've added the LU decomposition and now use this as the default in the kMatrix code. @henryiii can you have a look? If it's ok with you, I saw we merge it. |
henryiii
approved these changes
May 19, 2022
Co-authored-by: Henry Schreiner <hschrein@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the recursive determinant function with a templated version to avoid stack size issues. Marked draft for testing.
@danielsibemol @FlorianReiss