Skip to content

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Dec 30, 2021

This should be easier to read, and cleaner. Three changes:

  • Using classic return-type-first syntax for methods. The trailing return type was only added for special cases (where you need to compute the return type after the arguments), not for normal int's and floats.
  • Make methods const that do not change the ParameterContainer.
  • Make the parameter container copy the local one, rather than the one that's going to change. Make it const to ensure it remains the original PDF parameters.

@henryiii henryiii force-pushed the henryiii/refactor/pc_update branch from bc664af to 23d8c9e Compare December 30, 2021 04:43
@henryiii henryiii merged commit 87dab3a into master Dec 30, 2021
@henryiii henryiii deleted the henryiii/refactor/pc_update branch December 30, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant