Hello @henryiii @danielsibemol I think the checks are failing because of the submodules? Please can you check?

Eigen was accidentally deleted this weekend (!), so that's a bit of a mess right now. Should come back online soon, they are working with GitLab to get it restored.

Ok thanks @henryiii so now the checks are failing as expected because the pipipi0 example doesn't work. So we need to either:

• Change the pipipi0 example to include CPV or
• make deltax and deltay optional parameters (I'm not sure how to do this)

Can someone comment on what we think is the best solution? @danielsibemol @FlorianReiss

Ok thanks @henryiii so now the checks are failing as expected because the pipipi0 example doesn't work. So we need to either:

* Change the pipipi0 example to include CPV or

* make deltax and deltay optional parameters (I'm not sure how to do this)

Can someone comment on what we think is the best solution? @danielsibemol @FlorianReiss

to me the quickest solution seems to be to include CPV in the example. Maybe setting it constant to zero to recover the previous behaviour of the test

@marthaisabelhilton, @FlorianReiss, are deltax and deltay going to be fit? If that's the case, I suppose the easiest solution is to add them as fixed to 0 in the example as Florian suggested

Hi @danielsibemol @henryiii the tests are failing with a segmentation fault in the pipipi0 test please can you have a look? It seems to be failing when reading the data which shouldn't be affected by the changes on this MR?

Okay @danielsibemol @FlorianReiss this has been fixed now although I'm not sure it's a great solution. I have made the mistag and charmtag variables compulsory - not optional and changed the pipipi0 example to include these variables, set to zero.

Okay @danielsibemol @FlorianReiss this has been fixed now although I'm not sure it's a great solution. I have made the mistag and charmtag variables compulsory - not optional and changed the pipipi0 example to include these variables, set to zero.

to me that seems like a pragmatic solution for the moment

This still has "WIP" in the title? Is it ready for review?

Hi @henryiii it is ready for review yes. I have included CP violation and changed the example so that it works with my changes. The only problem is that it would not be backwards compatible as any code which does not include CPV would not work with my proposed changes. Cheers.