-
Notifications
You must be signed in to change notification settings - Fork 41
fix: support latest versions of some deps #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@henryiii, this OMP test is failing, as far as I understand, due to a change in the latest root version. Would you know how to fix it? I tried declaring an instance of MnPrint locally, but it didn't work. |
I think this was a change in root-project/root#6705. I'll try to look through that soon and see what changed. @HDembinski, does iMinuit provide a public pybind11 API for integrating custom classes? It would be nicer if this could simply register iMinuit classes instead of wrapping Minuit separately. |
Yes, it looks like that patch contains a breaking change - the static functions |
dd9a62b
to
d1afd28
Compare
Hi, I am not sure what you mean. The pybind11 wrapper for Minuit2 in iminuit is mostly a thin wrapper around the C++ code, while iminuit is built in Python on that foundation. There is one hybrid class, FCN, which overrides methods in FCNBase to call Python implementations. |
I improved the Printing in Minuit2 somewhat, but this is probably not the last change. The print level is still a global variable which causes problems with parallelization. |
ecd9ebc
to
7322daa
Compare
7322daa
to
f9bb089
Compare
pyproject.toml no longer pins exactly. Might have an issue with cmake 3.20 or the latest scikit-build, but hopefully we can work those out.
Supports ROOT 6.24's Minuit2 changes (and should work on old ROOTs too).
Updating pybind11, catch2, and Minuit2 (built-in). fmt is stuck at version 5 because newer versions don't support CUDA 8.
Added a noxfile so testing in a fresh, temporary virtual environment is simple and easy. Just run
nox
. (pipx run nox
if you have pipx but not nox).