-
Notifications
You must be signed in to change notification settings - Fork 41
Makefile cleanup #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Makefile cleanup #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explanatory comments..
…rho->K3Pi where K* and rho are in an s-wave. As one can easily see there still seems to be a problem though.. Spinfactors and lineshapes have been checked and are the same as in MINT.
…eems like there is still an error somewhere..
…rmalisation is not crashing anymore,not complety sure about results though
…utions are unchanged.. Cause still unclear!!.
…w the pions were switched. So a user mistake, no bug in the evaluation
…added some more spin factors
git subrepo clone --branch=GooFit https://github.com/hassec/MCBooster.git subrepo: subdir: "MCBooster" merged: "685a1db" upstream: origin: "https://github.com/hassec/MCBooster.git" branch: "GooFit" commit: "685a1db" git-subrepo: version: "0.3.0" origin: "https://github.com/ingydotnet/git-subrepo" commit: "cb2995b"
…corresponding to the created model. This is can later be used to add this functionality more generally to other pdf. EvalVar.h holds the struct to calculate the 5 variables m12, m34, cos12, cos34, and phi from the four vectors. Added new example to show usage of GenerateSig.
…ctors to multiply the lineshape with.
hassec
approved these changes
Jan 20, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the meeting, I have used this branch already and did not come across any problems, therefore I believe we can go ahead and merge this unless anybody thinks differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the "dev" branch that has had several examples added. I've merged it with the latest changes in master, and cleaned up the make file system. This includes all three cleanups planned. See #22.
Main features:
CMake is highly recommended, and should be much better than the old make builds. Those may go away at some point after this is merged.
Please build with both OMP and CUDA, and review!