Mhilton three gauss resolution #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62d1da3 to
5b29669
Compare
|
This should add a new GPU function that gets selected via the 9 argument form - the 8 argument form should remain unchanged. I can help with this later if needed. @danielsibemol let me know if you want to work on this together. |
added 2 commits
February 6, 2020 10:58
Add selection bias to ThreeGaussResolution. Add selection bias. Change -> to . Add selection bias to python binding. Fix formatting
5b29669 to
078e3a1
Compare
|
Since this is just adding a value that is 0, we'll leave it in as is, and user code will need to add constantZero (which is not too bad and keeps compile complexity down. |
danielsibemol
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding selection bias to ThreeGaussResolution.