Skip to content

Square dalitz eff pdf #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Nov 15, 2019
Merged

Square dalitz eff pdf #207

merged 49 commits into from
Nov 15, 2019

Conversation

marthaisabelhilton
Copy link
Collaborator

Dear GooFit experts,
I am trying to add this SquareDalitzEffPdf to GooFit and I'm wondering if you can help me.
When trying to build I am getting the following error:

/hepgpu5-data1/mhilton/GooFit/include/goofit/PdfBase.h(139): error: no instance of overloaded function "filter_arguments" matches the argument list
            argument types are: (std::vector<GooFit::Observable, std::allocator<GooFit::Observable>>, std::vector<GooFit::Variable, std::allocator<GooFit::Variable>>, std::vector<GooFit::Observable, std::allocator<GooFit::Observable>>, std::vector<GooFit::Variable, std::allocator<GooFit::Variable>>)
          detected during instantiation of "GooFit::PdfBase::PdfBase(std::__cxx11::string, std::__cxx11::string, Args...) [with Args=<std::vector<GooFit::Observable, std::allocator<GooFit::Observable>>, std::vector<GooFit::Variable, std::allocator<GooFit::Variable>>>]"

Please can you take a look at what might be wrong?
Many thanks.

@marthaisabelhilton marthaisabelhilton changed the title WIP: Square dalitz eff pdf Square dalitz eff pdf Sep 9, 2019
@marthaisabelhilton marthaisabelhilton changed the title Square dalitz eff pdf WIP: Square dalitz eff pdf Sep 10, 2019
@marthaisabelhilton
Copy link
Collaborator Author

Hi please would somebody be able to have a look at this?
I am getting some errors when trying to use this Pdf with my Amp3Body.
terminate called after throwing an instance of 'thrust::system::system_error' what(): function_attributes(): after cudaFuncGetAttributes: operation not supported on global/shared address space Aborted
Do you know what might be wrong?

@marthaisabelhilton marthaisabelhilton changed the title Square dalitz eff pdf WIP: Square dalitz eff pdf Sep 19, 2019
@marthaisabelhilton
Copy link
Collaborator Author

To provide some more information I see this is happening somewhere after line 244 in Amp3Body.cu in the normalize function. Also when I try to normalize the SquareDalitzEffPdf I get Non-positive normalization. I'm not sure why...

@marthaisabelhilton
Copy link
Collaborator Author

Hi I can provide a minimal working example of where I am trying to use this Pdf.
SquareDalitzEffPdf_test.py.txt

@henryiii
Copy link
Member

Okay, I'll try to take a look at it. Sorry for the delay!

@marthaisabelhilton
Copy link
Collaborator Author

Hi I have some more information about this which might help. I've been trying to add generic pdfs as the efficiency to Amp3Body ie. PolynomialPdf and SmoothHistogramPdf. A zeroth order PolynomialPdf works, anything else gives the following error:
terminate called after throwing an instance of 'thrust::system::system_error'
what(): function_attributes(): after cudaFuncGetAttributes: operation not supported on global/shared address space
Aborted
Maybe this can help with the problem?
Many thanks.

@henryiii henryiii changed the title WIP: Square dalitz eff pdf Square dalitz eff pdf Nov 15, 2019
@danielsibemol danielsibemol merged commit 05b9eea into master Nov 15, 2019
@henryiii henryiii deleted the SquareDalitzEffPdf branch November 15, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

@danielsibemol danielsibemol danielsibemol approved these changes

Assignees

@danielsibemol danielsibemol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marthaisabelhilton @henryiii @danielsibemol