Skip to content

Conversation

marthaisabelhilton
Copy link
Collaborator

Dear @henryiii and GooFit experts,
I am trying to add the kMatrix lineshape to the python bindings but it is not working. I was wondering if you could take a look to see if there is something wrong?
Many thanks.

@marthaisabelhilton
Copy link
Collaborator Author

marthaisabelhilton commented Aug 12, 2019

Hi @henryiii @galapaegos and others,
Is anyone able to have a look at this?
Sorry to bother you and many thanks for your help.

@henryiii
Copy link
Member

Sorry, I and my family have been sick this weekend. Will be getting back to work today.

martha and others added 2 commits August 14, 2019 10:21
Added getDecayInfo to python bindings.

Style fixes
@henryiii
Copy link
Member

I've simplified the history and applied the formatting, will address the actual problem next (computer is updating Xcode so can't build at the moment).

@henryiii henryiii changed the title WIP: Add kMatrix to Python bindings Add kMatrix to Python bindings Aug 15, 2019
@henryiii
Copy link
Member

I've changed the input to vector, then just check the size to make sure it is the correct size for f_scatter and matrix of poles - you can't default-construct an std::array, and it's not supported by default in pybind11 anyway.

@henryiii
Copy link
Member

Keep in mind, kMatix is experimental, and hasn't been throughly validated. It also is off by default on CUDA builds due to the amount of time it takes to compile.

@henryiii henryiii merged commit 216d8f2 into master Aug 15, 2019
@henryiii henryiii deleted the mhilton_mychanges branch August 15, 2019 19:14
@henryiii henryiii mentioned this pull request Jan 31, 2020
henryiii added a commit that referenced this pull request Jan 31, 2020
* Fix bug introduced in #202 (Python could not be run if kMatrix was off)
* Make sure goofit is importable
* Fix bug with `python -m goofit` randomly failing if no GPU present
    - Now prints number of GPUs present
* Respect GPU change request when GPU = 0 

Python + CUDA import now tested in CI!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants