Latest pybind11 master supports CUDA again #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50b794b to
6b145eb
Compare
6b145eb to
8e89d2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the latest PyBind master (not 2.2.4) supports CUDA again. This will remove the Python 3.7 warnings.
Also adding a check for CUDA version, and not building the four-body C++ examples if CUDA is 9 or higher.(Python bindings to 4-body should be fine).Edit: Fixed CUDA 9 support by moving
Application::runto be C++ compiled. Closes #173.@galapaegos, can you check with your older CMake & CUDA 9 or 10?
Also adds a bit of extra docstrings to the Python bindings.