-
Notifications
You must be signed in to change notification settings - Fork 41
Fixing spline #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing spline #181
Conversation
I'm getting some errors about a missing file 'files/DsPPP_TIS_PosTS_par_sPloted_large__MVA.root'. Can this file be provided under goofit_charm or another means? Thanks! |
I was able to run with no extra files. Are you changing to the subdirectory after building and before running? |
@galapaegos @henryiii |
I've just fixed D2PPP.cpp code. you can generate and fit a toy MC doing: ./D2PPP gen
./D2PPP fit This is the expected result |
I could be wrong, but don't you need to do: - dtoppp.resonances.push_back(rho_12);
- dtoppp.resonances.push_back(omega_12);
- dtoppp.resonances.push_back(f2_12);
- dtoppp.resonances.push_back(sigma_12);
- dtoppp.resonances.push_back(f0_980_12);
- dtoppp.resonances.push_back(f0_1500_12);
- dtoppp.resonances.push_back(nonr);
- //dtoppp.resonances.push_back(swave_12);
+ //dtoppp.resonances.push_back(rho_12);
+ //dtoppp.resonances.push_back(omega_12);
+ //dtoppp.resonances.push_back(f2_12);
+ //dtoppp.resonances.push_back(sigma_12);
+ //dtoppp.resonances.push_back(f0_12);
+ //dtoppp.resonances.push_back(nonr);
+ dtoppp.resonances.push_back(swave_12); to test it and get that result? |
I've make a fork with changes to make it easier to test: https://github.com/henryiii/goofit_charm, PR here: JuanBSLeite/goofit_charm#1. Also, you only need to run the |
Conflicts: src/PDFs/physics/resonances/Spline.cu
The images are very similar, but the latest changes provide a smoother image. The Spline constructor now calculates the derivatives and copies them to the internal buffer. |
@galapaegos, can you take a look? This doesn't work (trying to recover code which seems to have been commented out in GooFit 2.2.0).
@JuanBSLeite has code here that runs it: https://github.com/JuanBSLeite/goofit_charm - we could turn it into a test or an example. Or both.
cd goofit_charm ./D2PPP gen open plots/PDF.png