Skip to content

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Oct 5, 2018

@galapaegos, can you take a look? This doesn't work (trying to recover code which seems to have been commented out in GooFit 2.2.0).

@JuanBSLeite has code here that runs it: https://github.com/JuanBSLeite/goofit_charm - we could turn it into a test or an example. Or both.

cd goofit_charm
./D2PPP gen
open plots/PDF.png

@galapaegos
Copy link
Contributor

@henryiii, @JuanBSLeite

I'm getting some errors about a missing file 'files/DsPPP_TIS_PosTS_par_sPloted_large__MVA.root'. Can this file be provided under goofit_charm or another means? Thanks!

@henryiii
Copy link
Member Author

henryiii commented Oct 9, 2018

I was able to run with no extra files. Are you changing to the subdirectory after building and before running?

@JuanBSLeite
Copy link
Contributor

@galapaegos @henryiii
I'll fix it.

@JuanBSLeite
Copy link
Contributor

JuanBSLeite commented Oct 9, 2018

@henryiii @galapaegos

I've just fixed D2PPP.cpp code.

you can generate and fit a toy MC doing:

./D2PPP gen
./D2PPP fit

This is the expected result

pdf

@henryiii
Copy link
Member Author

I could be wrong, but don't you need to do:

-    dtoppp.resonances.push_back(rho_12);
-    dtoppp.resonances.push_back(omega_12);
-    dtoppp.resonances.push_back(f2_12);
-    dtoppp.resonances.push_back(sigma_12);
-    dtoppp.resonances.push_back(f0_980_12);
-    dtoppp.resonances.push_back(f0_1500_12);
-    dtoppp.resonances.push_back(nonr);
-    //dtoppp.resonances.push_back(swave_12);
+    //dtoppp.resonances.push_back(rho_12);
+    //dtoppp.resonances.push_back(omega_12);
+    //dtoppp.resonances.push_back(f2_12);
+    //dtoppp.resonances.push_back(sigma_12);
+    //dtoppp.resonances.push_back(f0_12);
+    //dtoppp.resonances.push_back(nonr);
+    dtoppp.resonances.push_back(swave_12);

to test it and get that result?

@henryiii
Copy link
Member Author

henryiii commented Oct 11, 2018

I've make a fork with changes to make it easier to test: https://github.com/henryiii/goofit_charm, PR here: JuanBSLeite/goofit_charm#1.

Also, you only need to run the ./D2PPP gen command to get that plot, fit not required (and the fit requires that background file).

@henryiii henryiii changed the title Fixing spline [WIP] Fixing spline Oct 11, 2018
@galapaegos galapaegos changed the title [WIP] Fixing spline Fixing spline Oct 11, 2018
@galapaegos
Copy link
Contributor

galapaegos commented Oct 11, 2018

The images are very similar, but the latest changes provide a smoother image. The Spline constructor now calculates the derivatives and copies them to the internal buffer.

@henryiii henryiii merged commit 5111f45 into master Oct 11, 2018
@henryiii henryiii deleted the spline branch October 11, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants