Skip to content

SmartVector #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2018
Merged

SmartVector #163

merged 2 commits into from
Jun 13, 2018

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Jun 1, 2018 •
edited
Loading

This removes the MAXPARAMS and MAXFUNCTs limits.

@henryiii henryiii force-pushed the smart_vector branch 4 times, most recently from 0cce753 to 4f4bd87 Compare June 5, 2018 12:09
@galapaegos
Copy link
Contributor

The BifurGaussTest failure is fixed under pc_fix.

@henryiii henryiii force-pushed the smart_vector branch 2 times, most recently from 2063b18 to eac8fe7 Compare June 11, 2018 15:56
@henryiii henryiii mentioned this pull request Jun 11, 2018
Merged
@henryiii henryiii force-pushed the smart_vector branch 3 times, most recently from e42340b to 4581538 Compare June 12, 2018 16:36
@henryiii henryiii mentioned this pull request Jun 12, 2018
Merged
@henryiii
Copy link
Member Author

henryiii commented Jun 12, 2018 •
edited
Loading

Thanks, I think that fixes it! Note to self: Check CUDA version before merging. OK

@henryiii henryiii changed the title WIP: SmartVector SmartVector Jun 12, 2018
@henryiii
Copy link
Member Author

Perfomance seems good, maybe even ~5% better than before. pipipi0DPFit canonical dataFiles/cocktail_pp_0.txt --blindSeed=0 -6 fails with efficiency zero NLL, but that happens now in master too. Going to merge.

@henryiii henryiii merged commit 74dbc36 into master Jun 13, 2018
@henryiii henryiii deleted the smart_vector branch June 13, 2018 06:24
@henryiii henryiii mentioned this pull request Jun 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @galapaegos