Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a proper MC method and a few example tests for 1D PDFs. This is using Catch2. The old tests have been moved to Catch; workarounds for GoogleTest are no longer needed.
Adds: pdf
fillMCDataSimple
, pdffit
, and datasetclear
; drops old experimental MC function.I've dropped the requirement that PDFs implement recursive set indices; while that still is overridable, normal PDFs only need to call
registerFunction("ptr_to_function", ptr_to_function)
(no more macros needed in user code). If they need special setup,populateArrays
is overridable (and can be called from the overridden function). Many features, like logging, are now built in and provided by default. SeeGaussianPDF
for an example of how simple and clean PDF definitions can be.Fit controls are now enum based only; the string method has been removed.
getName()
on a fit control will produce the old style name.