Skip to content

Most Python examples #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Nov 17, 2017
Merged

Most Python examples #126

merged 43 commits into from
Nov 17, 2017

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Nov 14, 2017 •
edited
Loading

This adds fixes and examples. The main changes are:

  • Python examples added/fixed Adding examples to Python #111
  • BinnedErrorFit and similar, setGenerationOffset added to Python
  • argc, argv no longer required in GOOFIT_PARSE
  • GLASS lineshape missing code added back
  • OpenMP now supported on macOS default compiler (using brew)
  • FitControl is now explicitly a std::shared_ptr, fixing bugs and simplifying bindings
  • print_goofit_info (and print_splash) added to Python
  • pyexamples/RunAll.sh added to run all examples, run by Travis
  • The include order is now checked by the clang-format run
  • The ModernizeGooFit is much more powerful, all "" includes changed to <>
  • py::keep_alive added for DecayInfoX structs

pandeyhs and others added 22 commits November 6, 2017 22:08
@pandeyhs
Added labels to ArgusPdf
3428c23
@pandeyhs
Manually merged upstream update
97696a0
@pandeyhs
updated argus pdf
2c85493
@henryiii
Merge branch 'master' into py_dev_hsp
3c7f518
@henryiii
Adding some changes
a521db5
@pandeyhs
added labels to bindings
4d9af4c
@pandeyhs
resolving merge conflicts
5f19016
@pandeyhs
added labels, updated keep alives, updated examples
da59c0c
@pandeyhs
Binded BinnedErrorFit
b0d89d4
@pandeyhs
chisquare example updated
b17080b
@henryiii
Adding OpenMP on Apple support
d8322e4
@henryiii
Adding missing lineshape base from Python
d8cc6ab
@henryiii
Reformat, add TDDP4::setGenerationOffset to python
944cc6a
@henryiii
Fixing setFitControl
8c2ee25
@henryiii
Removing need to add extra arguments to GOOFIT_PARSE
a0d0ca9
@henryiii
Adding constructor with fixed choice
b32783f
@henryiii
Fix for missing lines in GLASS
030aab0
@henryiii
Making the fit control a shared pointer
50ab59e
@henryiii
Reformat
23b0022
@henryiii
Fixing include order failure
4f1bf15
@henryiii
Dropping extra print, Tddp4 fix
90354e8
@henryiii
Adding info print to Python
2307910
@codecov
Copy link

codecov bot commented Nov 15, 2017 •
edited
Loading

Codecov Report

Merging #126 into master will decrease coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #126      +/-   ##
=========================================
- Coverage   68.58%   68.4%   -0.18%     
=========================================
  Files          34      34              
  Lines        1254    1247       -7     
  Branches      162     158       -4     
=========================================
- Hits          860     853       -7     
  Misses        394     394
Impacted Files Coverage Δ
include/goofit/fitting/FitManagerMinuit1.h 100% <ø> (ø) ⬆️
include/goofit/PDFs/basic/GaussianPdf.h 100% <ø> (ø) ⬆️
src/PDFs/combine/ProdPdf.cu 78% <ø> (ø) ⬆️
include/goofit/PDFs/physics/UserUtils.h 100% <ø> (ø) ⬆️
include/goofit/fitting/FCN.h 100% <ø> (ø) ⬆️
src/goofit/UnbinnedDataSet.cc 72.5% <ø> (ø) ⬆️
src/goofit/FitManagerMinuit1.cc 67.74% <ø> (ø) ⬆️
include/goofit/PdfBase.h 81.25% <ø> (ø) ⬆️
src/goofit/BinnedDataSet.cc 70.4% <ø> (ø) ⬆️
include/goofit/PDFs/physics/EvalVar.h 100% <ø> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a723d...d95098f. Read the comment docs.

@henryiii henryiii changed the title WIP: Python examples Most Python examples Nov 16, 2017
@henryiii henryiii force-pushed the py_dev_hsp branch 2 times, most recently from 31830d9 to d95098f Compare November 17, 2017 00:03
@henryiii henryiii merged commit 4a710b1 into master Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding examples to Python
2 participants
@henryiii @pandeyhs