Clean variable implementation #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## py_dev_hsp #124 +/- ##
==============================================
- Coverage 69.18% 68.58% -0.61%
==============================================
Files 34 34
Lines 1233 1254 +21
Branches 164 162 -2
==============================================
+ Hits 853 860 +7
- Misses 380 394 +14
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all1
Variables to pass by copy. All lifetime, etc. is handled inside theVariable, taking the burden off the programmer. This also makesDecayInfo...passable by value, and splits it into four versions,DecayInfo3,DecayInfo3t,DecayInfo4, andDecayInfo4t.The largest downside is that now there is no such thing as a "null" variable; this was poorly handled before, and required extra checks for
nullptr. I think this is less buggy than before.Several bugfixes included.
GooPdf now allows multiple observables in the default constructor.
Footnotes
One or two left as pointers, like in Tddp4, just to avoid duplicating the constructor initially. Should be converted eventually. ↩