Skip to content

Liang #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 58 commits into from
Oct 26, 2017
Merged

Liang #119

merged 58 commits into from
Oct 26, 2017

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Sep 22, 2017 •
edited
Loading

This adds:

  • Lineshapes are now split into subclasses, with unique constructors.
    • Could drop unneeded params
  • Resonances are also split
  • Variables support moving
  • Fit manager cleanups
  • Eigen input/output helpers added
  • Added Spline, KMatrix, FOCUS Lineshapes
  • Better selective and grid evaluation, with tests
  • Macros for setup (only used in Lineshapes for now)
  • Using CMake 3.9 FindCUDA, standardized to submodule, much cleaner
  • Moved and updated Eigen to 3.3.x with patch (may cause issues if checked out earlier version)

@codecov
Copy link

codecov bot commented Sep 22, 2017 •
edited
Loading

Codecov Report

Merging #119 into master will increase coverage by 11.42%.
The diff coverage is 88.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #119       +/-   ##
===========================================
+ Coverage   57.92%   69.34%   +11.42%     
===========================================
  Files          32       34        +2     
  Lines        1136     1233       +97     
  Branches      161      165        +4     
===========================================
+ Hits          658      855      +197     
+ Misses        478      378      -100
Impacted Files Coverage Δ
include/goofit/DataSet.h 100% <ø> (ø) ⬆️
include/goofit/BinnedDataSet.h 100% <ø> (ø) ⬆️
include/goofit/fitting/FitManagerMinuit1.h 100% <ø> (ø) ⬆️
include/goofit/PdfBase.h 50% <ø> (ø) ⬆️
src/goofit/UnbinnedDataSet.cc 72.5% <ø> (+10%) ⬆️
include/goofit/GlobalCudaDefines.h 100% <ø> (ø) ⬆️
include/goofit/UnbinnedDataSet.h 100% <ø> (ø) ⬆️
src/goofit/FitManagerMinuit1.cc 68.25% <ø> (ø) ⬆️
include/goofit/fitting/FitManagerMinuit2.h 100% <ø> (ø) ⬆️
include/goofit/fitting/FCN.h 100% <ø> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b14ada...87a057c. Read the comment docs.

@henryiii henryiii added this to the V 2.1 milestone Oct 21, 2017
@henryiii henryiii changed the title WIP: Liang Liang Oct 26, 2017
@henryiii henryiii merged commit cf0900b into master Oct 26, 2017
@henryiii henryiii deleted the liang branch October 26, 2017 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V 2.1
Development

Successfully merging this pull request may close these issues.
1 participant
@henryiii