Skip to content

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Aug 18, 2017

This pull request address several things:

  • Corrected IPO for Intel compilers on CMake 3.9 (untested)
  • Better Python library discovery
  • ResonancePdf now uses type enum parameter
  • Some changes from Liang Sun's branch (new ResonancePdf types)
  • Splash screen
  • Python printing now shows up in notebooks (live) PR accepted to PyBind11
  • fpcomplex shortcut
  • Macros for adding params
  • Source file move (closes Organize PDF folder into basic, combine, and physics subfolders #74)
  • Better grouping of PDFs in IDEs
  • RunAll run by Travis

@codecov
Copy link

codecov bot commented Aug 18, 2017

Codecov Report

Merging #114 into master will increase coverage by 41.57%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #114       +/-   ##
===========================================
+ Coverage   16.29%   57.87%   +41.57%     
===========================================
  Files         151       32      -119     
  Lines        6080     1137     -4943     
  Branches      493      161      -332     
===========================================
- Hits          991      658      -333     
+ Misses       5089      479     -4610
Impacted Files Coverage Δ
include/goofit/PdfBase.h 50% <ø> (+12.5%) ⬆️
src/PDFs/combine/ProdPdf.cu 78% <ø> (ø)
src/goofit/PdfBase.cc 48.48% <ø> (ø) ⬆️
src/PDFs/basic/GaussianPdf.cu 100% <ø> (ø)
include/goofit/GlobalCudaDefines.h 100% <ø> (ø) ⬆️
src/PDFs/basic/ExpPdf.cu 36.06% <0%> (ø)
src/goofit/DataSet.cc 67.39% <0%> (-10.87%) ⬇️
src/goofit/UnbinnedDataSet.cc 62.5% <0%> (-10%) ⬇️
include/goofit/PDFs/basic/ExpGausPdf.h
include/goofit/PDFs/basic/InterHistPdf.h
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d745f...4f3a32f. Read the comment docs.

@henryiii henryiii merged commit ef502e6 into master Aug 27, 2017
@henryiii henryiii deleted the liang branch August 27, 2017 04:59
@henryiii henryiii restored the liang branch August 27, 2017 04:59
@henryiii henryiii deleted the liang branch August 27, 2017 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize PDF folder into basic, combine, and physics subfolders
1 participant