Skip to content

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Aug 3, 2017

Fixes based on OpenSUSE docker and missing Minuit2 option for ROOT. Addresses #101.

This means you can now build and use GooFit with a copy of ROOT without Minuit2, since GooFit can use the stand-alone Minuit2 library.

@codecov
Copy link

codecov bot commented Aug 3, 2017

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   16.29%   16.29%           
=======================================
  Files         151      151           
  Lines        6080     6080           
  Branches      493      493           
=======================================
  Hits          991      991           
  Misses       5089     5089
Impacted Files Coverage Δ
python/goofit/PdfBase.cpp 83.33% <ø> (ø) ⬆️
src/goofit/PdfBase.cc 48.48% <ø> (ø) ⬆️
include/goofit/PdfBase.h 37.5% <ø> (ø) ⬆️
python/goofit/Version.cpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c0b0c...e15bb1b. Read the comment docs.

@henryiii henryiii merged commit 336e7ca into master Aug 3, 2017
@henryiii henryiii deleted the fixes_nominuit branch August 3, 2017 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant