Skip to content

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Jul 22, 2017

Several needed additions to make working in Python easier.

  • Variables can be tested for true/false, and return the same thing as C++.
  • fitTo works (but does not return a Minuit fit results)
  • Added generate for quick access to x and y values
  • Added filter option for from_numpy, and some named args and docstrings
  • Filled out more of Variable and DataSet, including min/max access

@codecov
Copy link

codecov bot commented Jul 22, 2017

Codecov Report

Merging #99 into master will increase coverage by 0.18%.
The diff coverage is 51.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   15.43%   15.61%   +0.18%     
==========================================
  Files         150      150              
  Lines        6019     6031      +12     
  Branches      496      493       -3     
==========================================
+ Hits          929      942      +13     
+ Misses       5090     5089       -1
Impacted Files Coverage Δ
include/goofit/PdfBase.h 37.5% <ø> (ø) ⬆️
python/goofit/Variable.cpp 83.33% <100%> (+2.38%) ⬆️
python/goofit/DataSet.cpp 100% <100%> (ø) ⬆️
src/goofit/PdfBase.cc 48.48% <100%> (+0.52%) ⬆️
python/goofit/UnbinnedDataSet.cpp 41.37% <14.28%> (-4.78%) ⬇️
python/PDFs/GooPdf.cpp 35.71% <18.18%> (-64.29%) ⬇️
src/PDFs/PdfBase.cu 84% <33.33%> (+10.24%) ⬆️
python/goofit/PdfBase.cpp 83.33% <75%> (-16.67%) ⬇️
include/goofit/DataSet.h 62.5% <0%> (-8.93%) ⬇️
include/goofit/Variable.h 84.61% <0%> (-4.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ff5a9...eef241e. Read the comment docs.

@henryiii henryiii merged commit e6998d8 into master Jul 31, 2017
@henryiii henryiii deleted the minor_additions branch July 31, 2017 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant