Skip to content

Conversation

pandeyhs
Copy link
Contributor

@pandeyhs pandeyhs commented Jun 9, 2017

Added all the basic pdfs, updated cmake and goofit file

@henryiii
Copy link
Member

henryiii commented Jun 9, 2017

@pandeyhs , I've merged this with master, since you seem to have started with an old branch. The merge was trivial, though.

@henryiii
Copy link
Member

henryiii commented Jun 9, 2017

I've fixed the build, you'll need to add the new PDFs to the python/CMakeLists.txt file. You'll also want to add them to the python/goofit.cpp file. I'd recommending adding at least one more test. I've added a note on testing, basically just run pytest in the build directory. Make sure you are building the bindings with cmake .. -DGOOFIT_PYTHON=ON. Looks great so far!

@codecov
Copy link

codecov bot commented Jun 9, 2017

Codecov Report

Merging #92 into master will decrease coverage by 42.2%.
The diff coverage is 92.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #92       +/-   ##
===========================================
- Coverage   58.68%   16.48%   -42.21%     
===========================================
  Files          41      139       +98     
  Lines        1220     5364     +4144     
  Branches      165      483      +318     
===========================================
+ Hits          716      884      +168     
- Misses        504     4480     +3976
Impacted Files Coverage Δ
python/PDFs/basic/ExpPdf.cpp 100% <ø> (ø)
python/goofit/DataSet.cpp 66.66% <ø> (ø)
python/goofit/UnbinnedDataSet.cpp 100% <ø> (ø)
python/goofit/BinnedDataSet.cpp 100% <ø> (ø)
python/goofit/PdfBase.cpp 100% <ø> (ø)
python/goofit/Variable.cpp 80.95% <ø> (ø)
python/goofit/FitManager.cpp 100% <ø> (ø)
python/PDFs/physics/TddpPdf.cpp 0% <0%> (ø)
python/PDFs/physics/Tddp4Pdf.cpp 0% <0%> (ø)
python/PDFs/physics/DalitzPlotPdf.cpp 100% <100%> (ø)
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f9140...5fee8b4. Read the comment docs.

@henryiii henryiii merged commit 4cbe922 into master Jun 21, 2017
@henryiii henryiii deleted the pdf-new branch June 21, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants