Skip to content

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented May 31, 2017

Cleanup for clang-tidy, fix mode is now a normal CMake variable. clang-format is now the supported formatter, with a make clang-format shortcut in the main directory.

  • Clean up make variables with '-L'

@codecov
Copy link

codecov bot commented May 31, 2017

Codecov Report

Merging #88 into master will decrease coverage by 0.08%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   58.83%   58.75%   -0.09%     
==========================================
  Files          41       41              
  Lines        1239     1222      -17     
  Branches      165      166       +1     
==========================================
- Hits          729      718      -11     
+ Misses        510      504       -6
Impacted Files Coverage Δ
include/goofit/UnbinnedDataSet.h 100% <ø> (ø) ⬆️
src/PDFs/GooPdf.cu 32.95% <ø> (ø) ⬆️
src/PDFs/PdfBase.cu 73.75% <ø> (+0.18%) ⬆️
src/goofit/Variable.cc 26.08% <ø> (+3.35%) ⬆️
src/PDFs/ExpPdf.cu 36.06% <ø> (ø) ⬆️
src/PDFs/GaussianPdf.cu 100% <ø> (ø) ⬆️
src/goofit/DataSet.cc 67.39% <ø> (-0.06%) ⬇️
src/goofit/BinnedDataSet.cc 70.4% <ø> (ø) ⬆️
src/goofit/FCN.cc 50% <ø> (+3.12%) ⬆️
src/goofit/FitManagerMinuit1.cc 68.25% <ø> (+1.04%) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2429fd9...e7691ec. Read the comment docs.

@henryiii henryiii merged commit 1974f4b into master May 31, 2017
@henryiii henryiii deleted the clang-tidy branch May 31, 2017 23:20
@henryiii henryiii modified the milestone: V 2.0 Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant