Skip to content

Variable #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 3, 2017
Merged

Variable #65

merged 21 commits into from
May 3, 2017

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Apr 28, 2017 •
edited
Loading

This provides a better variable reset mechanism. Changes:

  • Variables store a flag that is controlled by the FitManager (Minuit2 and Minuit1)
  • Minuit1 now avoids globals just like Minuit2
  • PDFs use variable cache flag to cache (multiple PDFs supported)
  • Better file discovery mechanism for examples, built into GooFit::Application
  • The abort with error print now throws an error vs. exit, making debugging easier, nice coloring, can be accessed from any __host__ PDF
  • Variables store Fitter and GooFit index, simplifying code and reducing bugs
  • Grid generation supported (ND) (getCombProb fn still 2D)
  • Initializer list supported in more places
  • Real tests: 1D and 2D exponential and prodPDF tested
  • All remaining warnings in Xcode fixed
  • CPP backend finally works with MCBooster

@codecov
Copy link

codecov bot commented Apr 28, 2017 •
edited
Loading

Codecov Report

Merging #65 into master will decrease coverage by 8.28%.
The diff coverage is 32.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   48.17%   39.89%   -8.29%     
==========================================
  Files          23       25       +2     
  Lines        1098     1118      +20     
  Branches      145      152       +7     
==========================================
- Hits          529      446      -83     
- Misses        569      672     +103
Impacted Files Coverage Δ
include/goofit/PDFs/GooPdf.h 20% <ø> (-20%) ⬇️
include/goofit/GlobalCudaDefines.h 100% <ø> (ø) ⬆️
include/goofit/fitting/Params.h 100% <ø> (ø) ⬆️
include/goofit/BinnedDataSet.h 0% <ø> (ø) ⬆️
src/goofit/UnbinnedDataSet.cc 27.16% <ø> (-6.18%) ⬇️
src/PDFs/GooPdf.cu 33.33% <0%> (-16.18%) ⬇️
include/goofit/Error.h 0% <0%> (ø)
src/goofit/BinnedDataSet.cc 0.75% <0%> (-0.03%) ⬇️
src/goofit/PdfBase.cc 34.4% <10.34%> (+4.48%) ⬆️
include/goofit/DataSet.h 66.66% <100%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3114f...6316c98. Read the comment docs.

@henryiii henryiii changed the title [WIP] Variable Variable May 2, 2017
@henryiii henryiii changed the base branch from cleanup to master May 2, 2017 19:31
@henryiii
Copy link
Member Author

henryiii commented May 2, 2017

@galapaegos or @hassec, let me know if there's a problem.

@henryiii henryiii merged commit b409bb8 into master May 3, 2017
@henryiii henryiii deleted the variable branch May 3, 2017 15:07
@henryiii henryiii mentioned this pull request May 3, 2017
Closed
@henryiii henryiii modified the milestone: V 2.0 Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V 2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@henryiii