Skip to content

MPI support #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Mar 30, 2017
Merged

MPI support #51

merged 39 commits into from
Mar 30, 2017

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Mar 20, 2017 •
edited
Loading

This is the new MPI support for GooFit.

galapaegos and others added 30 commits January 9, 2017 09:48
@galapaegos
Added ThrustOverride, which controls granularity of kernel's.
bdf8bb5 
Added policy's to GooPdf.
Added python script to find optimal group/grain size for a given problem.
@galapaegos
Merge remote dev to local dev
e6c33bb
@galapaegos
Using goofit policy for 'sumOfAll->transform_reduce' and 'normalise->…
57a79ed 
…transform_reduce'.
@galapaegos
Added override variables to CMakeLists
80132db
@galapaegos
Commit to add changes from previous version, rebase impossible for ne…
9236ba4 
…w version
@galapaegos
Merge branch 'mpi' of https://github.com/henryiii/GooFit into dev
c087ccc
@galapaegos
Renamed typedef's to match GOOFIT_MPI definition.
1f14d3f
@galapaegos
Added CLI options for pipipi, and added goofit::application
81f938e
@galapaegos
Committing MPI changes.
a16958b
@galapaegos
Removed extra calls in zachFit example. Added conditional fallbacks f…
2cdf30c 
…or OMP to not use goofit_policy
@henryiii
Fixing definition for MPI
d666585
@henryiii
Adding changelog mention of App
86ce9d3
@henryiii
Merge branch 'master' into mpi
81fa9bd
@galapaegos
Merge PR#36
4edafa6
@galapaegos
Removed extra endif
f86247d
@galapaegos
MPI needs to use m_iEventsPerTask rather than numEntries
f7826f6
@henryiii
Merge branch 'master' into mpi
c82cafb
@henryiii
Merge branch 'master' into mpi
4802e5c
@galapaegos
Removed CLI.hpp, name has changed. Added guards for ThrustOverride to…
c704ef4 
… compile for OMP
@galapaegos
Moving goofit_policy within definitions
b8fa281
@galapaegos
Added a ThrustOverrideConfig script, and added a flag when OMP is bei…
3665e80 
…ng used.
@galapaegos
Swapped GOOFIT_OMP with THRUST_SYSTEM_DEVICE_* check.
1abb766
@galapaegos
Specifically add hard definition of GOOFIT_MPI, does not work with MP…
df17c26 
…I_CXX_COMPILE_FLAGS
@galapaegos
Adding Makefile.common back in, will be removed in a future version
36e5f92 
Added CUDA override for group/grain size
Fixed code to use THRUST_DEVICE methods for checking CUDA vs OMP versions
@galapaegos
Merge branch 'mpi' into dev
f3b5ffc
@henryiii
Merge pull request #47 from galapaegos/dev
eef6e3a 
MPI version
@galapaegos
Adding initial documentation for MPI/Override
af475bd
@galapaegos
Printing best group and grain size, narrowed down initial search field.
5b751be
@galapaegos
Merge branch 'dev' of https://github.com/galapaegos/GooFit into dev
90b89aa
@galapaegos
Fixed typo's in the README.
02c1fce
@codecov
Copy link

codecov bot commented Mar 24, 2017 •
edited
Loading

Codecov Report

Merging #51 into master will decrease coverage by 0.07%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage    33.8%   33.73%   -0.08%     
==========================================
  Files          25       25              
  Lines        6552     6572      +20     
  Branches     1260     1261       +1     
==========================================
+ Hits         2215     2217       +2     
- Misses       4337     4355      +18
Impacted Files Coverage Δ
include/goofit/PdfBase.h 70.58% <ø> (ø) ⬆️
include/goofit/PDFs/GooPdf.h 40% <ø> (ø) ⬆️
src/goofit/PdfBase.cc 29.91% <0%> (-1.06%) ⬇️
src/PDFs/GooPdf.cu 49.5% <100%> (+0.16%) ⬆️
include/goofit/Variable.h 75% <50%> (ø) ⬆️
src/PDFs/PdfBase.cu 59.31% <50%> (-0.14%) ⬇️
src/goofit/Variable.cc 33.33% <7.69%> (-21.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c36440...96c4b05. Read the comment docs.

@henryiii henryiii changed the title [WIP] MPI support MPI support Mar 29, 2017
@henryiii
Copy link
Member Author

I think this is pretty close to being ready to merge. @galapaegos, please verify things still work on your end. The change I've made were:

  • Application help on parse failure only prints on one MPI thread
  • Fix segfault if PBS env variable is missing
  • GPU card was probably being reselected as 0, fixed
  • CountingVariable is now required at the API level for main PDFs, used in more examples
  • Reformatted to match rest of GooFit with astyle

Using toy 0 1 still gives odd warnings, but this happens with or without MPI.

@henryiii henryiii requested a review from galapaegos March 29, 2017 16:07
@galapaegos galapaegos added bug and removed bug labels Mar 30, 2017
galapaegos
galapaegos approved these changes Mar 30, 2017
View reviewed changes
Copy link
Contributor

@galapaegos galapaegos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes function well, no issues to report.

@henryiii henryiii merged commit d210ed5 into master Mar 30, 2017
@henryiii henryiii deleted the mpi branch April 1, 2017 02:54
@henryiii henryiii modified the milestone: V 2.0 Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galapaegos galapaegos galapaegos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V 2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @galapaegos