-
-
Notifications
You must be signed in to change notification settings - Fork 2
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersnix targetRelated to the nix target's codegenRelated to the nix target's codegenupstream-parityThings missing in Glistix compared to the upstream compilerThings missing in Glistix compared to the upstream compiler
Milestone
Description
Similarly to how Gleam now warns on unsafe integers on the JS target (see gleam-lang/gleam#3764), we could do the same for Nix since Nix restricts integer literals to between -9223372036854775807
and 9223372036854775808
(signed 64-bit integer values, though to get -9223372036854775808
it is necessary to write -9223372036854775807 - 1
).
builtins.fromJSON
for higher literals will simply convert to float, whereas, without fromJSON
, the literals just cause a parsing error (even if they're not evaluated). It could even straight up become a compilation error.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersnix targetRelated to the nix target's codegenRelated to the nix target's codegenupstream-parityThings missing in Glistix compared to the upstream compilerThings missing in Glistix compared to the upstream compiler