Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Guardsquare/proguard-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.1.5
Choose a base ref
...
head repository: Guardsquare/proguard-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.1.6
Choose a head ref
  • 9 commits
  • 30 files changed
  • 6 contributors

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    fc02d3a View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    a80d389 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Configuration menu
    Copy the full SHA
    b1772a7 View commit details
    Browse the repository at this point in the history
  2. Update kotest version

    mrjameshamilton authored and blendhamiti committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    5174a4b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55e2c85 View commit details
    Browse the repository at this point in the history
  4. Use DetailedArrayReferenceValue consistently for particular arrays in…

    … ExecutingInvocationUnit
    
    Summary:
    This solves the problem of particular array values being possibly `ParticularReferenceValue` or `DetailedArrayReferenceValue` based on how they are created. Now the latter is used consistently, also when a method tracked by `ExecutingInvocationUnit` returns a array of references.
    
    Other inconsistencies of how array are handled are still present and not addressed on purpose, since that behavior is present deeply in the PE code. For example, `ExecutingInvocationUnit#createNonParticularValue` still invokes `ValueFactory#createReferenceValue` even if the argument is an array, instead of `createArrayReferenceValue`, resulting in having an `IdentifiedReferenceValue` instead of an `IdentifiedArrayReferenceValue`. This is because values created outside the invocation unit use methods from `BasicValueFactory` and not overriden by the more advanced value factories, which also never end up invoking `ValueFactory#createArrayReferenceValue`. Trying to change this behavior to have consistency would probably be a longer process, so I'm keeping the code as it is.
    
    NB: the updated behavior will result in `ArrayReferenceValue` being created if `ArrayReferenceValueFactory` is used instead of `DetailedArrayValueFactory` and only in the case an array is returned by an executor (since `createValue` actually invokes `createArrayReferenceValue`), this inconsistency does not happen if `DetailedArrayValueFactory` is used with `ExecutingInvocationUnit`.
    
    In general the fix is quite hacky because it relies on `DetailedArrayValueFactory` calling the `referenceValueFactory` from `ParticularValueFactory` directly, since it needs to bypass the behavior of `IdentifiedValueFactory` because of some improper inheritance.
    capoz authored and blendhamiti committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    5893999 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    a00d7f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7877db6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    978cfce View commit details
    Browse the repository at this point in the history
Loading