-
Notifications
You must be signed in to change notification settings - Fork 69
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: Guardsquare/proguard-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.1.5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: Guardsquare/proguard-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.1.6
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 30 files changed
- 6 contributors
Commits on Jul 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fc02d3a - Browse repository at this point
Copy the full SHA fc02d3aView commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a80d389 - Browse repository at this point
Copy the full SHA a80d389View commit details
Commits on Aug 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b1772a7 - Browse repository at this point
Copy the full SHA b1772a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5174a4b - Browse repository at this point
Copy the full SHA 5174a4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55e2c85 - Browse repository at this point
Copy the full SHA 55e2c85View commit details -
Use DetailedArrayReferenceValue consistently for particular arrays in…
… ExecutingInvocationUnit Summary: This solves the problem of particular array values being possibly `ParticularReferenceValue` or `DetailedArrayReferenceValue` based on how they are created. Now the latter is used consistently, also when a method tracked by `ExecutingInvocationUnit` returns a array of references. Other inconsistencies of how array are handled are still present and not addressed on purpose, since that behavior is present deeply in the PE code. For example, `ExecutingInvocationUnit#createNonParticularValue` still invokes `ValueFactory#createReferenceValue` even if the argument is an array, instead of `createArrayReferenceValue`, resulting in having an `IdentifiedReferenceValue` instead of an `IdentifiedArrayReferenceValue`. This is because values created outside the invocation unit use methods from `BasicValueFactory` and not overriden by the more advanced value factories, which also never end up invoking `ValueFactory#createArrayReferenceValue`. Trying to change this behavior to have consistency would probably be a longer process, so I'm keeping the code as it is. NB: the updated behavior will result in `ArrayReferenceValue` being created if `ArrayReferenceValueFactory` is used instead of `DetailedArrayValueFactory` and only in the case an array is returned by an executor (since `createValue` actually invokes `createArrayReferenceValue`), this inconsistency does not happen if `DetailedArrayValueFactory` is used with `ExecutingInvocationUnit`. In general the fix is quite hacky because it relies on `DetailedArrayValueFactory` calling the `referenceValueFactory` from `ParticularValueFactory` directly, since it needs to bypass the behavior of `IdentifiedValueFactory` because of some improper inheritance.
Configuration menu - View commit details
-
Copy full SHA for 5893999 - Browse repository at this point
Copy the full SHA 5893999View commit details
Commits on Aug 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a00d7f1 - Browse repository at this point
Copy the full SHA a00d7f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7877db6 - Browse repository at this point
Copy the full SHA 7877db6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 978cfce - Browse repository at this point
Copy the full SHA 978cfceView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v9.1.5...v9.1.6