Skip to content

Fix .tpm suffix in ssh-tmp-keygen #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2023
Merged

Fix .tpm suffix in ssh-tmp-keygen #27

merged 1 commit into from
Oct 15, 2023

Conversation

rafiramadhana
Copy link
Contributor

Resolves #25

Tested in my local

Generating a sealed public/private ecdsa key pair.
Enter file in which to save the key (/root/.ssh/id_ecdsa): /root/.ssh/id_ecdsa_demo2.tpm
Enter pin (empty for no pin): 
Confirm pin: 
Your identification has been saved in /root/.ssh/id_ecdsa_demo2.tpm

@jtagcat
Copy link
Contributor

jtagcat commented Oct 14, 2023 •
edited
Loading

The separate function and checking are not needed. Trim already checks for suffix.

image

Instead, just change line 265 to filename = strings.TrimSuffix(filenameInput, ".tpm")

Thanks for finding the spot where to make the change and testing!

@rafiramadhana
Copy link
Contributor Author

The separate function and checking are not needed. Trim already checks for suffix.

image

Instead, just change line 265 to filename = strings.TrimSuffix(filenameInput, ".tpm")

Thanks for finding the spot where to make the change and testing!

updated ea50a8a

@rafiramadhana rafiramadhana temporarily deployed to Build, sign, release binaries October 15, 2023 10:10 — with GitHub Actions Inactive
@rafiramadhana rafiramadhana temporarily deployed to Build, sign, release binaries October 15, 2023 10:10 — with GitHub Actions Inactive
@rafiramadhana rafiramadhana temporarily deployed to Build, sign, release binaries October 15, 2023 10:10 — with GitHub Actions Inactive
@Foxboron
Copy link
Owner

Please squash the two commits.

@rafiramadhana
Fix suffix
b0b3a21 
Fix .tpm suffix in ssh-tmp-keygen.
@rafiramadhana
Copy link
Contributor Author

Please squash the two commits.

Ok, done

@rafiramadhana rafiramadhana temporarily deployed to Build, sign, release binaries October 15, 2023 11:49 — with GitHub Actions Inactive
@rafiramadhana rafiramadhana temporarily deployed to Build, sign, release binaries October 15, 2023 11:49 — with GitHub Actions Inactive
@rafiramadhana rafiramadhana temporarily deployed to Build, sign, release binaries October 15, 2023 11:49 — with GitHub Actions Inactive
@Foxboron Foxboron merged commit d0f23c9 into Foxboron:master Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foxboron Foxboron Foxboron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't add suffix if user added it already
3 participants
@rafiramadhana @jtagcat @Foxboron