feat: initial implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-godoy
requested changes
Aug 1, 2024
src/main/java/com/flowingcode/vaadin/addons/localecombobox/LocaleComboBox.java
Show resolved
Hide resolved
|
|
||
| private LitRenderer<Locale> getLocaleRenderer() { | ||
| return LitRenderer | ||
| .<Locale>of("<vaadin-horizontal-layout class=\"" + ITEM_LAYOUT_CLASS_NAME + "\">" |
There was a problem hiding this comment.
Since the minimum Java version is 17, you can use multiline text blocks, which don't require escaping ":
of("""
"a" "b"
""");
|
Hi, it looks good to me. One thing is that when I tried to test it locally I run into some issue |
|
Also note that some updates have been done to AddonsStarter 24 since you've created this repo, so you might need to do some updates:
|
javier-godoy
requested changes
Aug 5, 2024
javier-godoy
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.