Skip to content

fix: allow to add a footer to a one-column grid #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2023
Merged

fix: allow to add a footer to a one-column grid #94

merged 3 commits into from
Sep 25, 2023

Conversation

paodb
Copy link
Member

@paodb paodb commented Sep 21, 2023

Close #90

@paodb paodb requested a review from javier-godoy September 21, 2023 19:22
@javier-godoy javier-godoy changed the title Fix for issue 90 fix: allow to add a footer to a one-column grid Sep 21, 2023
javier-godoy
javier-godoy requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@javier-godoy javier-godoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI build failed.

@paodb
Copy link
Member Author

paodb commented Sep 22, 2023

CI build failed.

Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 61.295 s <<< FAILURE! - in com.flowingcode.vaadin.addons.gridhelpers.test.FooterToolbarTest
Error:  addToolbarFooter_toolbarFooterIsShown(com.flowingcode.vaadin.addons.gridhelpers.test.FooterToolbarTest)  Time elapsed: 61.291 s  <<< ERROR!
java.lang.ExceptionInInitializerError
Caused by: com.vaadin.pro.licensechecker.LicenseException: Unable to validate the license, please check your internet connection. If you need to work offline then please go to https://vaadin.com/pro/validate-license?getOfflineKey=mid-5a6f19fa-a1ec5b47 to retrieve an offline key. For troubleshooting steps, see https://vaadin.com/licensing-faq-and-troubleshooting.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paodb paodb requested a review from javier-godoy September 22, 2023 19:38
@javier-godoy javier-godoy merged commit 7766c88 into master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javier-godoy javier-godoy javier-godoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java.lang.IllegalArgumentException: Cannot join less than 2 cells error when adding footer to grid
2 participants
@paodb @javier-godoy