feat: add checkbox column helper #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-godoy
requested changes
Aug 11, 2023
| @@ -71,13 +75,15 @@ public AllFeaturesDemo() { | |||
|
|
|||
| grid.setColumnReorderingAllowed(true); | |||
|
|
|||
| grid.addColumn(Person::getLastName).setHeader("Last name").setHidingToggleCaption("Last name column"); | |||
| grid.addColumn(Person::getLastName).setHeader("Last name") | |||
| .setHidingToggleCaption("Last name column"); | |||
There was a problem hiding this comment.
Formatting changes in lines that are not modified
| grid.setSelectionMode(SelectionMode.MULTI); | ||
| grid.setItems(TestData.initializeData()); |
There was a problem hiding this comment.
Line moved, apparently unrelated to the implemented feature.
| @@ -178,12 +188,12 @@ public AllFeaturesDemo() { | |||
| binder.forField(heightByRowsField).bind(this::getHeightByRows, this::setHeightByRows); | |||
| updateHeightByRowsField(grid, heightByRowsField); | |||
| heightByRowsField.setStepButtonsVisible(true); | |||
|
|
|||
| @@ -0,0 +1,59 @@ | |||
| :host([theme~='checkbox-top']) .vaadin-checkbox-container [part="checkbox"] { | |||
There was a problem hiding this comment.
Use some prefix such as fcgh-checkbox-top in order to avoid collision with application-defined themes.
| */ | ||
|
|
||
| /* | ||
| * This file incorporates work licensed under the Apache License, Version 2.0 from Vaadin Cookbook |
There was a problem hiding this comment.
definitely not, gonna remove it
| */ | ||
|
|
||
| /* | ||
| * This file incorporates work licensed under the Apache License, Version 2.0 from Vaadin Cookbook |
There was a problem hiding this comment.
Which recipe is this code based on?
|
Kudos, SonarCloud Quality Gate passed!
|
javier-godoy
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that Vaadin's Grid doesn't provide a way to know when its dataprovider changes, if Select All checkbox is visible, and in order to keep it in sync with grid data, user must explicitly refresh the CheckboxColumn invoking refresh() method.
Close #69