Skip to content

feat: add select all support for grids using a lazy data provider #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2023
Merged

feat: add select all support for grids using a lazy data provider #87

merged 2 commits into from
Jul 14, 2023

Conversation

flang
Copy link
Contributor

@flang flang commented Jul 11, 2023

Close #70

@flang flang requested review from javier-godoy, mlopezFC and paodb July 11, 2023 12:23
@flang flang self-assigned this Jul 11, 2023
@flang flang added the enhancement New feature or request label Jul 11, 2023
javier-godoy
javier-godoy reviewed Jul 11, 2023
View reviewed changes
src/main/java/com/flowingcode/vaadin/addons/gridhelpers/GridHelper.java Outdated
@@ -477,6 +477,7 @@ public static double getHeightByRows(Grid<?> grid) {
* Defines the mode in which the Grid's height is calculated.
*
* <p>If {@link HeightMode#CSS} is given, Grid will respect the values given via a {@code
* If {@link HeightMode#CSS} is given, Grid will respect the values given via a {@code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

javier-godoy
javier-godoy reviewed Jul 11, 2023
View reviewed changes
src/main/java/com/flowingcode/vaadin/addons/gridhelpers/LazySelectAllGridHelper.java Outdated
*
* @param <T> the type of items in grid
*/
public final class LazySelectAllGridHelper<T> implements Serializable {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helper classes must not be public. Any public documentation about the feature goes into GridHelper

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

javier-godoy
javier-godoy requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@javier-godoy javier-godoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@javier-godoy javier-godoy self-requested a review July 14, 2023 13:52
javier-godoy
javier-godoy requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@javier-godoy javier-godoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash fix: implement review requested changes into feat: add select all support for grids using a lazy data provider, and remember to re-request review after changes are pushed.

@flang flang requested a review from javier-godoy July 14, 2023 17:14
@javier-godoy javier-godoy merged commit 7978950 into master Jul 14, 2023
@javier-godoy javier-godoy deleted the issue-70 branch July 14, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javier-godoy javier-godoy javier-godoy approved these changes

@mlopezFC mlopezFC Awaiting requested review from mlopezFC

@paodb paodb Awaiting requested review from paodb

Assignees

@flang flang

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select All support for Lazy Loading
2 participants
@flang @javier-godoy