Skip to content

Conversation

javier-godoy
Copy link
Member

This is a breaking change:

  • Compatibility with Existing Code: If the ErrorWindow component is widely used in an application, other parts of the application may rely on the current behavior, which allows HTML-formatted error messages. Changing this behavior could break existing code that expects HTML-formatted messages.
  • User Expectations: Users of the application may expect error messages to be displayed in a specific format, such as with HTML formatting. Changing this behavior could result in unexpected changes in how errors are presented to users.
  • Security Implications: Allowing HTML formatting in error messages can be risky, as it opens up the possibility of script injection attacks, where malicious code can be injected into error messages. While this is a security concern, changing the behavior to interpret messages in a text-only format could break applications that rely on legitimate HTML formatting for error messages.

Close #74

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@paodb paodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paodb paodb merged commit 0abcb6f into master Sep 14, 2023
@paodb paodb deleted the fix-74 branch September 14, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error window creation fails if the error text contains html
2 participants