Skip to content

feature: add i18n support #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2023
Merged

feature: add i18n support #54

merged 2 commits into from
Jan 19, 2023

Conversation

flang
Copy link
Collaborator

@flang flang commented Jan 4, 2023

Close #43

@flang flang requested review from javier-godoy and paodb January 4, 2023 13:47
javier-godoy
javier-godoy requested changes Jan 4, 2023
View reviewed changes
Copy link
Member

@javier-godoy javier-godoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change (both in API and behavior). Either provide backward compatibility or target a new major version.

@flang flang requested a review from javier-godoy January 6, 2023 12:05
@javier-godoy javier-godoy merged commit f78e120 into master Jan 19, 2023
@javier-godoy javier-godoy deleted the fix-issue-43 branch January 19, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javier-godoy javier-godoy javier-godoy approved these changes

@paodb paodb Awaiting requested review from paodb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Custom I18n setting
2 participants
@flang @javier-godoy