Skip to content

refactor: initialize ErrorWindow on attach #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2022
Merged

refactor: initialize ErrorWindow on attach #46

merged 1 commit into from
Oct 31, 2022

Conversation

javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Oct 19, 2022 •
edited
Loading

Also initialize it the first time that getChildren is called (even if it isn't attached) in order to allow reusing the dialog contents in
ErrorView:

ErrorWindowAddon/src/main/java/com/flowingcode/vaadin/addons/errorwindow/ErrorView.java

Lines 44 to 49 in 42449d2

new ErrorWindow(parameter.getCaughtException(), i18n) {
@Override
public void close() {
UI.getCurrent().getPage().getHistory().back();
}
}.getChildren().forEach(this::add);

Close #44

@javier-godoy
refactor: initialize ErrorWindow on attach
3a0904b 
Also initialize it the first time that getChildren is called (even if it isn't attached) in order to allow reusing the dialog contents in ErrorView.

Close #44
@paodb paodb merged commit 376370e into master Oct 31, 2022
@paodb paodb deleted the refactor-errorWindow-init branch October 31, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paodb paodb paodb approved these changes

@mlopezFC mlopezFC Awaiting requested review from mlopezFC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ErrorWindow constructor should not call overridable methods
2 participants
@javier-godoy @paodb