-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add initial implementation #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/test/java/com/flowingcode/vaadin/addons/chatbot/ChatAssistantDemoView.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java
Outdated
Show resolved
Hide resolved
src/test/java/com/flowingcode/vaadin/addons/chatassistant/it/BasicIT.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/chatassistant/Message.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/chatassistant/Message.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/chatassistant/Message.java
Outdated
Show resolved
Hide resolved
src/main/resources/META-INF/frontend/styles/chat-assistant-styles.css
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(test) is not a scope
According to https://github.com/FlowingCode/DevelopmentConventions/blob/main/conventional-commits.md commits that contribute to a test are of type test:
test: Adding missing tests or refactoring/fixing existing tests
Updating webdrivermanager is either build
or ci
, depending on your interpretation of "exported artifact"
build: Changes to the build process or external dependencies affecting the exported artifacts (i.e. those artifacts that are created as a result of such process, and are utilized as final deliverables or included in other external projects). Correlates with a PATCH, MINOR or MAJOR increment in semantic versioning, depending on the nature of the change
ci: Changes to the CI configuration, and other changes to the build process or external dependencies with no impact in the exported artifacts (e.g.: configure code quality metrics, add dependencies that are only needed for running unit tests). Does not correlate with an increment in semantic versioning, because the versioned artifacts are not modified
Otherwise, LGTM
Replace with primitive boolean because null state is not supported
98ace07
to
1696b70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also @flang and @javier-godoy are invited to take a look