Skip to content

Fixed crash if dbus is not accesible #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fixed crash if dbus is not accesible #458

merged 1 commit into from
Feb 14, 2024

Conversation

Trial97
Copy link
Contributor

@Trial97 Trial97 commented Jan 5, 2024

When running an application without dbus connection I get the following crash:

GameMode ERROR: Could not connect to bus: Failed to connect to socket /run/firejail/mnt/dbus/user: Permission denied
dbus[5]: arguments to dbus_connection_unref() were incorrect, assertion "connection != NULL" failed in file ../../../dbus/dbus-connection.c line 2832.
This is normally a bug in some application using the D-Bus library.

  D-Bus not built with -rdynamic so unable to print a backtrace

I'm well aware that gamemode will not run without dbus but for the calling real_gamemode_query_status function I would expect the function to just return the fact that it's not accessible( by returning -1) and not just close the app if failed.

@Trial97
Fixed crash if dbus is not accesible
d82329c 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 mentioned this pull request Jan 5, 2024
Closed
1 task
@afayaz-feral afayaz-feral merged commit 3fa4189 into FeralInteractive:master Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trial97 @afayaz-feral