Add ReplayBuffer #55
Closed
Add ReplayBuffer #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Howuhh
reviewed
Apr 7, 2023
minari/replay_buffer.py
Outdated
| assert observation_space.shape is not None | ||
| assert action_space.shape is not None | ||
|
|
||
| self._obs = np.zeros((self.max_size, *observation_space.shape), dtype=observation_space.dtype) |
There was a problem hiding this comment.
I think in more general implementation, buffer should use here gym.spaces.unflatten to provide observations samples in their original shape
There was a problem hiding this comment.
@Howuhh Thanks for the review; I am working on it!
Are you in our Discord channel? Can you drop me a message? (younik)
There was a problem hiding this comment.
Can we make the unflatten optional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a draft for ReplayBuffer