Skip to content

build: Export Git Version Information #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2023
Merged

build: Export Git Version Information #1381

merged 2 commits into from
Mar 30, 2023

Conversation

ChristianTackeGSI
Copy link
Member

If building a specific git commit, try to export that information.

fixes: #1076

Checklist:

@ChristianTackeGSI ChristianTackeGSI added this to the v19.0 milestone Mar 24, 2023
@ChristianTackeGSI ChristianTackeGSI linked an issue Mar 24, 2023 that may be closed by this pull request
feature request: Get installed FairRoot version as git identifier from derived projects #1076
Closed
@ChristianTackeGSI ChristianTackeGSI mentioned this pull request Mar 24, 2023
Closed
dennisklein
dennisklein reviewed Mar 27, 2023
View reviewed changes
@ChristianTackeGSI ChristianTackeGSI marked this pull request as draft March 27, 2023 16:10
@ChristianTackeGSI ChristianTackeGSI force-pushed the pr/cmake branch 2 times, most recently from a38b75d to 6455ae7 Compare March 27, 2023 22:27
@ChristianTackeGSI ChristianTackeGSI marked this pull request as ready for review March 27, 2023 22:36
karabowi
karabowi requested changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@karabowi karabowi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the information printed by the FindFairRoot.cmake about this newly introduced FairRoot_GIT_VERSION variable?

@ChristianTackeGSI ChristianTackeGSI marked this pull request as draft March 29, 2023 15:39
@ChristianTackeGSI
build: Export Git Version Information
e05679b 
If building a specific git commit, try to export that
information.

fixes: FairRootGroup#1076
@ChristianTackeGSI
docs: Fix some Doxygen warnings
01849fd
@ChristianTackeGSI
Copy link
Member Author

Okay, added to FindFairRoot.cmake.

See output here: https://cdash.gsi.de/testDetails.php?test=13940650&build=379814

@ChristianTackeGSI ChristianTackeGSI marked this pull request as ready for review March 29, 2023 19:45
@ChristianTackeGSI ChristianTackeGSI merged commit 01849fd into FairRootGroup:dev Mar 30, 2023
@ChristianTackeGSI ChristianTackeGSI deleted the pr/cmake branch March 30, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karabowi karabowi karabowi approved these changes

@dennisklein dennisklein Awaiting requested review from dennisklein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v19.0
Development

Successfully merging this pull request may close these issues.

feature request: Get installed FairRoot version as git identifier from derived projects
3 participants
@ChristianTackeGSI @dennisklein @karabowi